-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blocked] Rename user to owner #753
Conversation
@jstriebel There are still type errors which I assume to be due to a differing setup for the client generation. These are the errors:
I saw that the client generation expects a dataset |
This is indeed quite tricky. The When using the local docker-compose setup from the wk-libs repo (which is spawned automatically, but only if nothing is running on port 9000), then this dataset always exists, as it is checked into this repo. It's not quite ideal for a setup, but I'm also not sure, how to change it. Maybe it would be best to simply ignore possible local setups by default and use another port for the client generation? I'd be super happy about suggestions and improvements :-)
This is a separate issue. Here, the generated client uses a sentinel object (basically a singleton) Since I was assigned issue #719, I fixed the same problems on PR #760 and also included the deprecations for the username etc. I'll close this PR therefore, but let's still discuss how to improve the setup. |
Description:
owner
property instead ofuser
since the latter one is deprecated.Issues:
Todos:
Make sure to delete unnecessary points or to check all before merging: