Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local Dockerfile used for spec changes to be in line with github workflows #19718

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Update local Dockerfile used for spec changes to be in line with github workflows #19718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/_spec/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ RUN apt-get install -y curl \
&& apt-get install -y nodejs \
&& curl -L https://www.npmjs.com/install.sh | sh

RUN gem update --system
RUN gem install "rubygems-update:<3.5" --no-document
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken directly from the spec.yml

RUN update_rubygems

RUN gem install sass-embedded -v 1.58.0
RUN gem install bundler:1.17.2 jekyll
RUN gem install bundler:2.3.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundler file we have is built using this version according to the logs. Bumping this means that we don't need to pull a second version.


WORKDIR /srv/jekyll

Expand Down
1 change: 1 addition & 0 deletions docs/_spec/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# To build the spec on Travis CI
source "https://rubygems.org"
ruby "~> 2.7"

gem "jekyll", "3.6.3"
gem "webrick"
Expand Down
Loading