Update local Dockerfile used for spec changes to be in line with github workflows
#19718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilinwei
commented
Feb 17, 2024
| RUN gem install sass-embedded -v 1.58.0 | ||
| RUN gem install bundler:1.17.2 jekyll | ||
| RUN gem install bundler:2.3.5 |
There was a problem hiding this comment.
The bundler file we have is built using this version according to the logs. Bumping this means that we don't need to pull a second version.
yilinwei
commented
Feb 17, 2024
| @@ -7,9 +7,11 @@ RUN apt-get install -y curl \ | |||
| && apt-get install -y nodejs \ | |||
| && curl -L https://www.npmjs.com/install.sh | sh | |||
|
|
|||
| RUN gem update --system | |||
| RUN gem install "rubygems-update:<3.5" --no-document | |||
There was a problem hiding this comment.
Taken directly from the spec.yml
yilinwei
changed the title
Dockerfile to be in line with github workflowsDockerfile used for spec changes to be in line with github workflows
bishabosha
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the local server for the spec fails to build with the same issue as in #19288 on a fresh docker build.
This is the minimum amount of changes to actually get the spec building for users to make changes. I highly recommend updating all the versions when #19716 is finished.