Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A slightly more conservative version of #14218 #18352

Merged
merged 1 commit into from
Aug 8, 2023

Commits on Aug 7, 2023

  1. A slightly more conservative version of #14128

    Two changes
    
     - Fix `hasUpperBound` to work correctly for higher-kinded types
     - A more conservative fix in `IsFullyDefinedAccumulator`. We now maintain
       the symmetry that
    
         - if variance < 0, we maximize
         - if variance > 0 (and Nothing is admissible) we minimize
         - only if variance = 0, we use the upper bound as a tie breaker
    
       Previously, we maximized even if variance > 0 if there was an upper but
       no lower bound. But that was asymmetric since there is no corresponding
       case where we minimize at variance < 0 if there is a lower but no upper
       bound.
    odersky committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    0faa252 View commit details
    Browse the repository at this point in the history