A slightly more conservative version of #14218 #18352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes
- Fix `hasUpperBound` to work correctly for higher-kinded types
- A more conservative fix in `IsFullyDefinedAccumulator`. We now maintain
the symmetry that
- if variance < 0, we maximize
- if variance > 0 (and Nothing is admissible) we minimize
- only if variance = 0, we use the upper bound as a tie breaker
Previously, we maximized even if variance > 0 if there was an upper but
no lower bound. But that was asymmetric since there is no corresponding
case where we minimize at variance < 0 if there is a lower but no upper
bound.
dwijnand
changed the title
dwijnand
approved these changes
Aug 8, 2023
This was referenced Aug 9, 2023
Kordyjan
added a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to #14218
Fix
hasUpperBoundto work correctly for higher-kinded typesA more conservative fix in
IsFullyDefinedAccumulator. We now maintain the symmetry thatPreviously, we maximized even at variance > 0 if there was an upper but no lower bound. But that was asymmetric since there is no corresponding case where we minimize at variance < 0 if there is a lower but no upper bound.