Fix hardhat-deploy compatibility #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outdoteth
changed the title
Contributor
Author
|
cc @wighawag |
outdoteth
changed the title
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 22 22
Lines 986 986
=======================================
Hits 973 973
Misses 13 13
Continue to review full report at Codecov.
|
outdoteth
force-pushed
the
fix-network-modification
branch
2 times, most recently
from
f3c7394 to
81ce0a6
Compare
outdoteth
force-pushed
the
fix-network-modification
branch
from
0ad71ee to
2894cee
Compare
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624, fixes #640, and fixes wighawag/hardhat-deploy#132
There is another PR opened here for the same issue #643 but the owner has not responded to the any comments for 6 days now so I thought I would address the issues in his PR and fix it myself.
By changing it so that the network config object is only modified instead of replaced we can ensure other existing plugins which have also modified the network config will have their changes persisted instead of being overwritten.
Object.assign also keeps the original reference of the object, so that if any other variables in other plugins are referencing the network object, their references will remain valid (this was the issue in the other PR^^ which needed fixing).
I also added a fix for the "Berlin network error" by bumping the hardhat version (which uses Berlin as the default now):