Add missing hardhat network variables #643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 22 22
Lines 986 986
=======================================
Hits 973 973
Misses 13 13
Continue to review full report at Codecov.
|
| env.config.networks[networkName] = networkConfig; | ||
| env.config.defaultNetwork = networkName; | ||
|
|
||
| env.network = { |
There was a problem hiding this comment.
The fact that it still create a new object will cause issue with plugin that modify the network object before this is called.
It is better to simply modify the network object
There was a problem hiding this comment.
I'm using the fork with this fork and seems to be working well with hardhat deploy :)
If they modify it before, it shouldn't be an issue since we first set all previous object values then only override the needed ones ...env.network.
If you meant using Object.assign I believe the main difference would only be that setters are called on the object. According to a random SO answer: "spread operator will not copy the the source object’s prototype to the target object"
How would you suggest this be implemented? Glad to iterate on it or take a PR heh
There was a problem hiding this comment.
Plugins could have copied the reference to hre.network before and will later modify an unrelated object. Modifying the network object would be safer. I proposed this in that comment: wighawag/hardhat-deploy#132 (comment)
There was a problem hiding this comment.
Object.assign retains the reference to the original object too. I think that is more conventional. But simplicity is always good so maybe @wighawag solution of just doing inplace modifications (env.network.name = networkName etc.) is better.
5 participants
Fixes #624, fixes #640, and fixes wighawag/hardhat-deploy#132
Proposed fix inspired from discussions in
hardhat-deployissue 132