Chore: Change the settings so the project scanner may work on different setups #13
Conversation
| } else { | ||
| logger.info('not using env script') | ||
| scriptFileBuffer.push( | ||
| `export PYTHONPATH=${this._pathToBitbakeFolder}/lib:$PYTHONPATH`, |
There was a problem hiding this comment.
Why is this required? I have not yet encountered cases were I needed to tweak the PATH to run bitbake. This is usually done by oe_init_build_env.
There was a problem hiding this comment.
It is a fallback in case there is no environment script, so the extension still can attempt to work. Maybe it should just fail?
There was a problem hiding this comment.
Yes there will always be an environment file for calling bitbake. It is the recommended workflow.
There was a problem hiding this comment.
Understood. I'll make this work into this PR: #16
idillon-sfl
force-pushed
the
Chore-change-configuration-settings
branch
from
ef8cec9
to
c745070
Compare
idillon-sfl
force-pushed
the
Chore-change-configuration-settings
branch
from
c745070
to
1916897
Compare
idillon-sfl
force-pushed
the
Chore-change-configuration-settings
branch
from
1916897
to
12f0eb5
Compare
| return this.executeCommand(scriptFileName) | ||
| private executeBitBakeCommand (command: string): string { | ||
| const scriptContent: string = this.generateBitBakeCommand(command) | ||
| return this.executeCommand(scriptContent) |
There was a problem hiding this comment.
I don't see code checking that the command did succeed. Is it done by the libary by throwing?
There was a problem hiding this comment.
spawnSync won't throw an error, but return a "SpawnSyncReturns" object, which contains both stderr and stdout. BitBake syntax errors are included into "stderr" and are not error for us.
| ## Set BitBake's path | ||
| Some features require to know where your BitBake's folder is located. The extension will by default assume it is located at the root of the project in a folder named `bitbake`. If your BitBake folder is located somewhere else, set its path in the settings in order to have full features. | ||
| ## Setup the extension | ||
| In order to work properly, the extension needs to know your Bitbake's location and build folder. It will make the following assumptions: |
There was a problem hiding this comment.
Maybe we can be more specific than "work properly". The extension highlighting works without for instance. Maybe just "For all the features to be enabled,"
There was a problem hiding this comment.
I'd also rephrase "it will make the following assumptions" -> "It will look for it at these default locations"
There was a problem hiding this comment.
Lets remove it it in PR #16
| "default": "vscode-bitbake-build", | ||
| "description": "Use this setting to specify the build folder. Use other folder than for your regular 'build' to avoid collisions." | ||
| "default": "oe-init-build-env", | ||
| "description": "Set the path to the environment script to configure the BitBake project. If the file does not exist, the extension will attempt to configure the environment variables by itself." |
There was a problem hiding this comment.
I don't think we should attempt to configure the variables ourselves. Let's always ask for an env script as is the recommended Yocto workflow.
server/src/BitBakeProjectScanner.ts
Outdated
| } | ||
| } catch (error: any) { |
There was a problem hiding this comment.
I'm not sure we should catch the error here because we don't know how to handle it. All callers will also have to check for errors. Error handling should be done at the calling level that can recover, or abort and display an error message.
There was a problem hiding this comment.
This code is outdated, it does not exist anymore
|
I'll aprove this PR since those fixes are addressed in other PRs. |
No description provided.