Fix: Fix parseAllRecipes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
idillon-sfl
commented
Oct 6, 2023
idillon-sfl
commented
- Lines with parsing errors are underlined
- Use spawnSync instead of execSync
- Improve handling of errors for child_process
- Simplify parts of code
- Move 'rescanProject' to onDidChangeConfiguration
- Lines with errors are underlined - Use spawnSync instead of execSync - Improve handling of errors for child_process - Simplify parts of code
deribaucourt
requested changes
Oct 9, 2023
This allow the user to fix their configuration after opening the workspace. This also removes the timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.