Skip to content

Conversation

@Borketh
Copy link
Member

@Borketh Borketh commented Sep 30, 2024

This is just some CI stuff at the moment. PK compat is not even started yet but I wanted to put this on the table for now.

@Borketh
Copy link
Member Author

Borketh commented Sep 30, 2024

I think half of these commits are already live on master

@Borketh Borketh self-assigned this Sep 30, 2024
apparently it hasn't been working for a while because str(bytes) includes the b'' around the string... that has been replaced with a map(bytes.decode) for proper lazy eval
for whatever reason the python:3.12-alpine is minor version 7 while apk add python3-dev is minor version 6

this makes poetry throw a bus error of all things and breaks the build process

to fix this we just use the base alpine image and install python ourselves
@Borketh Borketh changed the title 2.23.0 - CI fixes, PluralKit compatibility 2.22.11 - CI improvements and minor bug fixes Oct 6, 2024
@Borketh Borketh marked this pull request as ready for review October 6, 2024 01:19
@Borketh Borketh requested a review from Feyko October 6, 2024 01:19
@Borketh Borketh changed the title 2.22.11 - CI improvements and minor bug fixes 2.22.11 - mediaonly forums, fixes, CI improvements Oct 9, 2024
@Feyko Feyko self-requested a review October 11, 2024 21:19
Feyko
Feyko previously approved these changes Oct 11, 2024
@Borketh Borketh merged commit 3e65a8f into dev Oct 11, 2024
1 check passed
@Borketh Borketh deleted the bork-fixes branch October 11, 2024 21:27
@Borketh Borketh restored the bork-fixes branch October 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

3 participants