Skip to content

Remove DialogFlow entirely #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 11, 2024
Merged

Remove DialogFlow entirely #147

merged 8 commits into from
Oct 11, 2024

Conversation

@Borketh
Copy link
Member

@Borketh Borketh commented Oct 10, 2024

We don't use this at all and don't seem to intend to, so it's not worth having in our codebase

@Borketh Borketh changed the title Remove DialogFflow entirely Remove DialogFlow entirely Oct 10, 2024
@Borketh
Copy link
Member Author

Borketh commented Oct 10, 2024

Without Dialogflow:
image
with:
image
This is because the google-cloud-dialogflow library and its dependencies are big and have compiled parts.

@Feyko
Copy link
Member

Feyko commented Oct 11, 2024

Missed a mention in experience.py and the tables could be removed from the example.sql, though they should get dropped when the DB gets migrated at startup I think (to test, maybe)

@Borketh Borketh marked this pull request as ready for review October 11, 2024 21:23
@Borketh Borketh requested a review from Feyko October 11, 2024 21:23
@Borketh Borketh merged commit 17cf3a6 into bork-fixes Oct 11, 2024
@Borketh Borketh deleted the no-dialogflow branch October 11, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Feyko Feyko Awaiting requested review from Feyko

Assignees

No one assigned

Labels

None yet

Projects

FICSIT-Fred
Status: ✅ Completed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Borketh @Feyko