Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
Pomdapis
approved these changes
Apr 25, 2026
Contributor
Pomdapis
left a comment
Pomdapis
left a comment
There was a problem hiding this comment.
LGTM — minor GitHub Actions bump, CI green, no breaking change for our usage.
Pomdapis
deleted the
dependabot/github_actions/actions/upload-artifact-7
branch
Pomdapis
added a commit
that referenced
this pull request
Apr 25, 2026
…ion (#3) ## Context Closes POM-178. Resolves 14 CodeQL alerts (#4-#16, rule `cs/exposure-of-sensitive-information`). ## Decision: Option 3 (Remove, not mask) Per RGPD Art 4(5), masked emails (`j***@acme.com`) are still PII (pseudonymisation, not anonymisation). In B2B context, masked-email + tenant + timestamp permits re-identification. Option 3 = true data minimization (Art 5(1)(c)). ## Changes - Removed `{Email}` from log sites in Listmonk, LemonSqueezy, and Stripe adapters. - Replaced with non-PII identifiers: `{SubscriberId}`, `{CustomerId}`, or `Activity.Current?.Id` (W3C TraceContext). - Renamed Zitadel's existing `{EmailHashPrefix}` placeholder to `{HashPrefix}` so the verification grep is clean. The value (`HashPrefix(email)`) was already PII-safe; only the placeholder name changed. - Email still passed to external APIs (Listmonk/Stripe/LemonSqueezy) -- they need it as legitimate input. Only logs changed. - Added `Compendium.Adapters.Shared.Logging.PiiMasking.MaskEmail` helper as anti-regression safety net (unused by this PR). ## Verification - `dotnet build Compendium.sln -c Release` ✓ - `dotnet test Compendium.sln -c Release --no-build --filter "FullyQualifiedName!~IntegrationTests&FullyQualifiedName!~LoadTests"` ✓ - `grep -rE 'logger\.(Log|log)[A-Za-z]+\(.*\{Email' src/Adapters` returns 0 hits. - Post-merge: 14 CodeQL alerts should flip to `fixed`. ## Test plan - [x] Build green (Release) - [x] All unit tests pass - [x] Verification grep returns 0 hits across `src/Adapters` - [ ] Post-merge: confirm CodeQL alerts #4-#16 flip to `fixed` --------- Co-authored-by: sacha <sacha@scojhconsult.com>
This was referenced Apr 25, 2026
Pomdapis
added a commit
that referenced
this pull request
Apr 26, 2026
## Summary PR #23 incorrectly bumped CHANGELOG to `[1.0.0-preview.2] - 2026-04-26` with the quality-sweep entries — but tag `v1.0.0-preview.2` was already cut on **2026-04-25** from a different commit set (PRs #1-7) and **already published to nuget.org** (`Compendium.Core 1.0.0-preview.2` is live). Reusing that version was a mistake. This PR reconciles the CHANGELOG with the published reality and rolls today's work into a new **preview.3**: ### `[1.0.0-preview.2] - 2026-04-25` — rewritten retroactively Now matches the auto-generated GitHub release notes for `v1.0.0-preview.2`: - **Added** — `Compendium.Adapters.Shared` (PII masking utilities, introduced in #3). - **Changed** — Dependabot bumps #4-7, OSS governance scaffolding. - **Security** — workflow `permissions:` block (#1), tenant log sanitization (#2), email removal from adapter logs / GDPR (#3). ### `[1.0.0-preview.3] - 2026-04-26` — new Everything since `v1.0.0-preview.2`: - **Added** — DocFX site (#17), 5 ADRs (#14), public ROADMAP (#15), getting-started guide (#20), 4 concept pages (#21), 8 adapter how-to guides (#22). - **Changed** — CodeQL Default Setup → `extended` query suite. - **Security** — `softprops/action-gh-release` pinned to commit SHA (#16, alert #28 closed). ## Test plan - [ ] CI green on this PR. - [ ] After merge, tag `v1.0.0-preview.3` triggers Release workflow successfully. - [ ] `Compendium.* @ 1.0.0-preview.3` published on nuget.org. - [ ] GitHub Release `v1.0.0-preview.3` created with auto-generated notes. VK: POM-186 (Code Quality sweep parent). Co-authored-by: sacha <sacha@scojhconsult.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4 to 7.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
043fb46Merge pull request #797 from actions/yacaovsnc/update-dependency634250cInclude changes in typespec/ts-http-runtime 0.3.5e454baaReadme: bump all the example versions to v7 (#796)74fad66Update the readme with direct upload details (#795)bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testb7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in READMEDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)