Skip to content

chore(ci): pin softprops/action-gh-release to commit SHA#16

Merged
Pomdapis merged 4 commits intomainfrom
vk/1426-compendium-quali
Apr 26, 2026
Merged

chore(ci): pin softprops/action-gh-release to commit SHA#16
Pomdapis merged 4 commits intomainfrom
vk/1426-compendium-quali

Conversation

@Pomdapis
Copy link
Copy Markdown
Contributor

Summary

  • Pins softprops/action-gh-release from @v3 (mutable tag) to commit SHA b4309332981a82ec1c5618f44dd2e27cc8bfbfda (= v3.0.0).
  • Closes CodeQL alert chore(deps): bump actions/setup-dotnet from 4 to 5 #28 (actions/unpinned-tag, CWE-829).
  • First-party actions/* refs are intentionally left as tags (not flagged by the rule).

Test plan

Closes #28 via CodeQL.

Closes CodeQL alert #28 (actions/unpinned-tag, CWE-829).
3rd-party actions must be pinned by commit SHA to prevent
supply-chain risk from mutable tag refs.

VK: https://vibekanban.com (issue 693eb9c3-1549-43e7-aaff-84466cfe0dfe)
Copilot AI review requested due to automatic review settings April 25, 2026 08:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the third-party GitHub Action used to create releases to an immutable commit SHA to address a CodeQL actions/unpinned-tag alert and reduce supply-chain risk in the release workflow.

Changes:

  • Replaces softprops/action-gh-release@v3 with a specific commit SHA (b430933...) corresponding to v3.0.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Pomdapis Pomdapis enabled auto-merge (squash) April 25, 2026 08:33
@Pomdapis Pomdapis disabled auto-merge April 26, 2026 11:34
@Pomdapis Pomdapis merged commit 159f520 into main Apr 26, 2026
4 checks passed
@Pomdapis Pomdapis deleted the vk/1426-compendium-quali branch April 26, 2026 11:34
Pomdapis added a commit that referenced this pull request Apr 26, 2026
## Summary

PR #23 incorrectly bumped CHANGELOG to `[1.0.0-preview.2] - 2026-04-26`
with the quality-sweep entries — but tag `v1.0.0-preview.2` was already
cut on **2026-04-25** from a different commit set (PRs #1-7) and
**already published to nuget.org** (`Compendium.Core 1.0.0-preview.2` is
live). Reusing that version was a mistake.

This PR reconciles the CHANGELOG with the published reality and rolls
today's work into a new **preview.3**:

### `[1.0.0-preview.2] - 2026-04-25` — rewritten retroactively

Now matches the auto-generated GitHub release notes for
`v1.0.0-preview.2`:
- **Added** — `Compendium.Adapters.Shared` (PII masking utilities,
introduced in #3).
- **Changed** — Dependabot bumps #4-7, OSS governance scaffolding.
- **Security** — workflow `permissions:` block (#1), tenant log
sanitization (#2), email removal from adapter logs / GDPR (#3).

### `[1.0.0-preview.3] - 2026-04-26` — new

Everything since `v1.0.0-preview.2`:
- **Added** — DocFX site (#17), 5 ADRs (#14), public ROADMAP (#15),
getting-started guide (#20), 4 concept pages (#21), 8 adapter how-to
guides (#22).
- **Changed** — CodeQL Default Setup → `extended` query suite.
- **Security** — `softprops/action-gh-release` pinned to commit SHA
(#16, alert #28 closed).

## Test plan

- [ ] CI green on this PR.
- [ ] After merge, tag `v1.0.0-preview.3` triggers Release workflow
successfully.
- [ ] `Compendium.* @ 1.0.0-preview.3` published on nuget.org.
- [ ] GitHub Release `v1.0.0-preview.3` created with auto-generated
notes.

VK: POM-186 (Code Quality sweep parent).

Co-authored-by: sacha <sacha@scojhconsult.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants