Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use extends instead of spreading default theme #34

Merged
merged 1 commit into from
Sep 18, 2023
Merged

docs: use extends instead of spreading default theme #34

merged 1 commit into from
Sep 18, 2023

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Sep 17, 2023

Spreading the default theme when enhanceApp is specified prevents registering some of the vitepress components like badges that other people might be using.

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2023

⚠️ No Changeset found

Latest commit: fe1af23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Owner

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! TIL the extends feature

@sapphi-red sapphi-red merged commit 668f60d into sapphi-red:main Sep 18, 2023
@brc-dd brc-dd deleted the update-theme-entrypoint branch September 18, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants