Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): change env vars from secrets to env #7601

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Oct 7, 2024

Description

This changes some remaining references to secrets in the e2e workflow after #7598 moved them to env vars.

What to review

Did I miss any?

Testing

CI passes, I guess?

Notes for release

n/a

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 2:49pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 2:49pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 2:49pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 2:49pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 2:49pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 2:49pm

Copy link
Contributor

github-actions bot commented Oct 7, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Component Testing Report Updated Oct 7, 2024 2:51 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 7, 2024

⚡️ Editor Performance Report

Updated Mon, 07 Oct 2024 15:03:08 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.7 efps (57ms) 17.9 efps (56ms) -1ms (-0.9%)
article (body) 60.1 efps (17ms) 60.2 efps (17ms) -0ms (-0.3%)
article (string inside object) 19.6 efps (51ms) 18.9 efps (53ms) +2ms (+3.9%)
article (string inside array) 14.8 efps (68ms) 14.7 efps (68ms) +1ms (+0.7%)
recipe (name) 31.7 efps (32ms) 31.3 efps (32ms) +1ms (+1.6%)
recipe (description) 34.5 efps (29ms) 34.5 efps (29ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) -0ms (-/-%)
synthetic (title) 15.4 efps (65ms) 15.9 efps (63ms) -2ms (-3.1%)
synthetic (string inside object) 15.9 efps (63ms) 15.5 efps (65ms) +2ms (+2.4%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 57ms 63ms 93ms 137ms 1143ms 14.3s
article (body) 17ms 21ms 34ms 165ms 225ms 6.4s
article (string inside object) 51ms 54ms 64ms 111ms 802ms 8.6s
article (string inside array) 68ms 73ms 82ms 184ms 1795ms 10.1s
recipe (name) 32ms 34ms 36ms 56ms 17ms 8.8s
recipe (description) 29ms 30ms 36ms 123ms 0ms 6.3s
recipe (instructions) 6ms 8ms 9ms 23ms 0ms 3.2s
synthetic (title) 65ms 70ms 77ms 341ms 1969ms 17.0s
synthetic (string inside object) 63ms 67ms 71ms 325ms 1695ms 10.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 56ms 59ms 70ms 207ms 1049ms 13.1s
article (body) 17ms 18ms 20ms 61ms 104ms 5.3s
article (string inside object) 53ms 56ms 64ms 100ms 775ms 8.7s
article (string inside array) 68ms 71ms 78ms 193ms 1754ms 10.1s
recipe (name) 32ms 35ms 39ms 61ms 41ms 9.8s
recipe (description) 29ms 31ms 36ms 131ms 52ms 6.4s
recipe (instructions) 6ms 8ms 10ms 24ms 0ms 3.2s
synthetic (title) 63ms 65ms 74ms 132ms 1626ms 14.5s
synthetic (string inside object) 65ms 70ms 79ms 455ms 2188ms 10.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if all the env. needed changing - but seems to still be building?

@bjoerge bjoerge added this pull request to the merge queue Oct 7, 2024
Merged via the queue into next with commit 7868c0b Oct 7, 2024
63 checks passed
@bjoerge bjoerge deleted the ci-fix-missing-env-vars branch October 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants