chore(ci): use environment variables, not secrets, for non-sensitive vars #7598

rexxars · 2024-10-05T14:53:51Z

Description

I don't think there's any reason to hide variables such as dataset and project IDs. It makes it harder to debug issues and read logs, as any value in these secrets will be scrubbed from logs as ****. In particular, we use test as a dataset name 😅

What to review

CI configs still looks right
Environment variables are in place to take the place of the secrets

Testing

Letting the CI workflows run should be enough

Notes for release

None

…vars

vercel · 2024-10-05T14:53:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:53pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:53pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:53pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:53pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:53pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Oct 5, 2024 2:53pm

github-actions · 2024-10-05T14:54:43Z

No changes to documentation

ryanbonial

👍 looks good

github-actions · 2024-10-05T15:00:10Z

Component Testing Report Updated Oct 5, 2024 3:00 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	44s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	8s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	30s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	37s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	11s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	2m 33s	1	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	44s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 37s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 16s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	9s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	26s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	34s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-05T15:11:07Z

⚡️ Editor Performance Report

Updated Sat, 05 Oct 2024 15:11:06 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	18.9 efps (53ms)	17.9 efps (56ms)	+3ms (+5.7%)	✅
article (body)	61.5 efps (16ms)	63.3 efps (16ms)	-0ms (-2.8%)	✅
article (string inside object)	19.2 efps (52ms)	19.2 efps (52ms)	+0ms (-/-%)	✅
article (string inside array)	14.8 efps (68ms)	14.9 efps (67ms)	-1ms (-0.7%)	✅
recipe (name)	31.3 efps (32ms)	32.3 efps (31ms)	-1ms (-3.1%)	✅
recipe (description)	35.7 efps (28ms)	35.7 efps (28ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	15.0 efps (67ms)	15.2 efps (66ms)	-1ms (-0.8%)	✅
synthetic (string inside object)	15.9 efps (63ms)	16.4 efps (61ms)	-2ms (-3.2%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	53ms	56ms	62ms	213ms	1010ms	13.6s
article (body)	16ms	18ms	21ms	102ms	197ms	5.3s
article (string inside object)	52ms	55ms	62ms	229ms	898ms	8.7s
article (string inside array)	68ms	72ms	78ms	173ms	1577ms	9.9s
recipe (name)	32ms	34ms	38ms	59ms	23ms	9.1s
recipe (description)	28ms	31ms	36ms	163ms	24ms	6.4s
recipe (instructions)	6ms	8ms	9ms	10ms	0ms	3.1s
synthetic (title)	67ms	70ms	78ms	258ms	2040ms	16.7s
synthetic (string inside object)	63ms	66ms	72ms	273ms	1704ms	10.1s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	56ms	59ms	71ms	107ms	999ms	13.5s
article (body)	16ms	18ms	20ms	111ms	142ms	5.1s
article (string inside object)	52ms	54ms	59ms	137ms	803ms	8.7s
article (string inside array)	67ms	70ms	76ms	280ms	1681ms	10.0s
recipe (name)	31ms	32ms	47ms	92ms	73ms	10.1s
recipe (description)	28ms	30ms	35ms	87ms	57ms	6.2s
recipe (instructions)	6ms	8ms	9ms	20ms	0ms	3.3s
synthetic (title)	66ms	71ms	92ms	316ms	2045ms	17.8s
synthetic (string inside object)	61ms	65ms	77ms	310ms	1785ms	9.6s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

…vars (#7598) ### Description I don't think there's any reason to hide variables such as dataset and project IDs. It makes it harder to debug issues and read logs, as any value in these secrets will be scrubbed from logs as `****`. In particular, we use `test` as a dataset name 😅 ### What to review - CI configs still looks right - [Environment variables](https://github.com/sanity-io/sanity/settings/variables/actions) are in place to take the place of the secrets ### Testing Letting the CI workflows run should be enough ### Notes for release None

### Description This changes some remaining references to secrets in the e2e workflow after #7598 moved them to env vars. ### What to review Did I miss any? ### Testing CI passes, I guess? ### Notes for release n/a

chore(ci): use environment variables, not secrets, for non-sensitive …

bb990be

…vars

rexxars requested a review from a team as a code owner October 5, 2024 14:53

rexxars requested review from ryanbonial and removed request for a team October 5, 2024 14:53

ryanbonial approved these changes Oct 5, 2024

View reviewed changes

rexxars added this pull request to the merge queue Oct 5, 2024

Merged via the queue into next with commit af71d46 Oct 5, 2024
62 of 63 checks passed

rexxars deleted the chore/ci-use-env-vars-for-non-secrets branch October 5, 2024 15:04

bjoerge mentioned this pull request Oct 7, 2024

chore(ci): change env vars from secrets to env #7601

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): use environment variables, not secrets, for non-sensitive vars #7598

chore(ci): use environment variables, not secrets, for non-sensitive vars #7598

rexxars commented Oct 5, 2024

vercel bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

ryanbonial left a comment

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

chore(ci): use environment variables, not secrets, for non-sensitive vars #7598

chore(ci): use environment variables, not secrets, for non-sensitive vars #7598

Conversation

rexxars commented Oct 5, 2024

Description

What to review

Testing

Notes for release

vercel bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

ryanbonial left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 5, 2024

github-actions bot commented Oct 5, 2024

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions