Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base] RFC: Provide a way to configure client initially #76

Closed
wants to merge 1 commit into from

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented May 9, 2017

This lets us e.g. look at the url to figure out the dataset to use. What do you think, @rexxars?

@bjoerge bjoerge requested a review from rexxars May 9, 2017 09:25
@bjoerge bjoerge force-pushed the feature/client-config-hook branch 2 times, most recently from 0a7c784 to fe92436 Compare May 9, 2017 14:19
@bjoerge bjoerge force-pushed the feature/client-config-hook branch from fe92436 to 78361ee Compare May 10, 2017 11:40
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bjoerge
Copy link
Member Author

bjoerge commented May 11, 2017

Done deal!

@bjoerge bjoerge closed this May 11, 2017
@bjoerge bjoerge deleted the feature/client-config-hook branch May 11, 2017 12:59
bjoerge pushed a commit that referenced this pull request Feb 15, 2018
bjoerge pushed a commit that referenced this pull request Feb 15, 2018
kristofferjs pushed a commit that referenced this pull request Feb 27, 2018
* [components] Click to scroll for block editor #76

* [form-builder] Check scroll height on new props.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants