Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Click to scroll for block editor #76 #578

Merged
merged 2 commits into from
Feb 27, 2018

Conversation

kristofferjs
Copy link
Contributor

We had som problems with this earlier.
But I think this is more stable. Anyway: We need to test this properly before merging.

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested now. Seems that "click to edit" only works when the field is scrolled initially. E.g. if I edit a block field so that it becomes scrollable, and moves focus to another field, "click to edit" is not enabled.

@kristofferjs kristofferjs reopened this Feb 26, 2018
@kristofferjs
Copy link
Contributor Author

@bjoerge This seems to be fixed. If i start writing and put in more content than the max width, blurs the field, it triggers. 👍

@kristofferjs kristofferjs merged commit c28dbff into next Feb 27, 2018
@kristofferjs kristofferjs deleted the enhancement/click-to-active branch February 27, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants