-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL-1093 - As developers we want to find out how to modify the e2e fixtures so we can re-use the factory wrapper that we are creating so we do not have to duplicate requests #1756
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6c0aa6b
chore: Update PacbioSmrtLinkVersionFactory import in pacbio_run_creat…
stevieing d4d69ac
chore: Update PacbioSmrtLinkVersionFactory import in edit and view
stevieing 1b04290
create a BaseFactory which has an axios and fetch response.
stevieing 62da47a
Added extra data to Axios response. Removed e2e fixture.
stevieing 8f84887
chore: Update printers.json with correct attribute names.
stevieing 057e0f4
Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t…
stevieing 3da0345
Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t…
stevieing 8ba0519
Remove RequestFactory and replace it's usage with new style factory f…
stevieing 27d8ac9
Remove printers.json from tests/data.
stevieing ae74d40
Add storePrinters to printers factory.
stevieing b4b665f
chore: Update PacbioSmrtLinkVersionFactory to use dataToObjectById ut…
stevieing dd50cb8
Remove use of smrt link version data.
stevieing 7d0c36c
Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t…
stevieing 2684f7e
Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t…
stevieing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/** | ||
* | ||
* @param {*} data | ||
* @returns {Object} {content: {...data}, responses: {axios: {...}, fetch: {...} } | ||
* A base factory that returns an object with a content key that contains the data passed in and a responses key that contains an axios and fetch key that contains the data passed in. | ||
*/ | ||
|
||
const BaseFactory = (data) => { | ||
return { | ||
content: { ...data }, | ||
responses: { | ||
axios: { | ||
status: 200, | ||
statusText: 'OK', | ||
data: { ...data }, | ||
}, | ||
fetch: { | ||
status: 200, | ||
statusText: 'OK', | ||
ok: true, | ||
json: () => Promise.resolve({ ...data }), | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
export default BaseFactory |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice abstraction 👍