Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL-1093 - As developers we want to find out how to modify the e2e fixtures so we can re-use the factory wrapper that we are creating so we do not have to duplicate requests #1756

Merged
merged 14 commits into from
Jun 19, 2024
Merged

DPL-1093 - As developers we want to find out how to modify the e2e fixtures so we can re-use the factory wrapper that we are creating so we do not have to duplicate requests #1756

merged 14 commits into from
Jun 19, 2024

Commits on Jun 14, 2024

  1. chore: Update PacbioSmrtLinkVersionFactory import in pacbio_run_creat… 

    …e.cy.js
    @stevieing
    stevieing committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6c0aa6b View commit details
    Browse the repository at this point in the history

  2. chore: Update PacbioSmrtLinkVersionFactory import in edit and view

    @stevieing
    stevieing committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d4d69ac View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. create a BaseFactory which has an axios and fetch response.

    @stevieing
    stevieing committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1b04290 View commit details
    Browse the repository at this point in the history

  2. Added extra data to Axios response. Removed e2e fixture.

    @stevieing
    stevieing committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    62da47a View commit details
    Browse the repository at this point in the history

  3. chore: Update printers.json with correct attribute names. 

    Created a printers factory.
    @stevieing
    stevieing committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8f84887 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t… 

    …o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
    @stevieing
    stevieing committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    057e0f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t… 

    …o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
    @stevieing
    stevieing committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3da0345 View commit details
    Browse the repository at this point in the history

  2. Remove RequestFactory and replace it's usage with new style factory f… 

    …or Printers.
    @stevieing
    stevieing committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8ba0519 View commit details
    Browse the repository at this point in the history

  3. Remove printers.json from tests/data.

    @stevieing
    stevieing committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    27d8ac9 View commit details
    Browse the repository at this point in the history

  4. Add storePrinters to printers factory.

    @stevieing
    stevieing committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ae74d40 View commit details
    Browse the repository at this point in the history

  5. chore: Update PacbioSmrtLinkVersionFactory to use dataToObjectById ut… 

    …ility function.

Use smrt link factory in pacbioRunCreate store.
    @stevieing
    stevieing committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b4b665f View commit details
    Browse the repository at this point in the history

  6. Remove use of smrt link version data. 

    Create Pacbio Run factory for use in view.

Fix incorrect naming and add some consistency.
    @stevieing
    stevieing committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    dd50cb8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t… 

    …o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
    @stevieing
    stevieing committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7d0c36c View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'develop' into 1659-dpl-1093-2---as-developers-we-want-t… 

    …o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
    @stevieing
    stevieing committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2684f7e View commit details
    Browse the repository at this point in the history