Detect the presence of getauxval and elf_aux_info #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lines to the Makefile-generated config.h so HAVE_GETAUXVAL or HAVE_ELF_AUX_INFO is set when appropriate. Add lines to Makefile and simd.c to set HAVE_ELF_AUX_INFO on a recent enough OpenBSD. Part of this check needs to be in simd.c because it pulls in sys/param.h, which defines some macros (notable MIN and MAX) that don't get on with the rest of HTSlib, and so need to be limited in scope. This can be simplified later once OpenBSD versions without elf_aux_info() are no longer supported.
|
I've added a commit which should ensure I've tested this both with and without |
|
@daviesrob Thanks. That looks reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.