Fix problems found attempting to build on i686 #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ax_check_compile_flag to use AC_LINK_IFELSE so that it can't cheat by making implicit declarations of the symbols we're testing for. Include _mm256_extract_epi64() in the AVX2 tests. This only exists on X86_64, so trying to build the AVX2 code on i686 didn't work.
Apparently `if (sizeof(time_t) < 8)` isn't enough to keep the compiler from warning about the code that only runs when it's bigger.
It gets upset because in theory the combination of prefix and filename could be longer than the value snprintf() can return. Trying to use a filename that long would be somewhat bizarre.
jkbonfield
added a commit
to jkbonfield/htscodecs
that referenced
this pull request
Aug 17, 2022
On this platform _mm256_extract_epi64 isn't defined, but the rest of AVX2 is. It needs to fail auto-detection. Also we get unaligned accesses in the SSE4 code with tbuf due to differing data alignment caused by 32-bit pointers instead of 64-bit. This exposes an underlying problem of using aligned SIMD writes on tbuf without explicitly asking for alignment. (The new code is also sometimes a little faster.) See also samtools/htslib#1500
daviesrob
pushed a commit
to samtools/htscodecs
that referenced
this pull request
Aug 25, 2022
On this platform _mm256_extract_epi64 isn't defined, but the rest of AVX2 is. It needs to fail auto-detection. Also we get unaligned accesses in the SSE4 code with tbuf due to differing data alignment caused by 32-bit pointers instead of 64-bit. This exposes an underlying problem of using aligned SIMD writes on tbuf without explicitly asking for alignment. (The new code is also sometimes a little faster.) See also samtools/htslib#1500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_mm256_extract_epi64(), used by the AVX2 rANS codec, is only available on X86_64. Adding it to the configure tests prevents it from being used on i686. Also change theax_check_compile_flagtest so it runs the linker, which catches missing symbols better than just running the compiler.Fix some overflow warnings in the test_time_funcs program, when
time_tis only four bytes long.Silence an annoying gcc-10 format-truncation warning.