Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAM tiny refactor: remove CramCompressionRecord.tagIds #1345

Merged
merged 1 commit into from
May 6, 2019
Merged

Conversation

jmthibault79
Copy link
Contributor

@jmthibault79 jmthibault79 commented Apr 3, 2019

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

@jmthibault79
Copy link
Contributor Author

It was only used inside one method. So now it's declared there.

@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #1345 into master will increase coverage by 0.302%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##              master    #1345       +/-   ##
==============================================
+ Coverage     67.848%   68.15%   +0.302%     
- Complexity      8283     8449      +166     
==============================================
  Files            563      563               
  Lines          33706    34314      +608     
  Branches        5657     5821      +164     
==============================================
+ Hits           22869    23385      +516     
- Misses          8659     8732       +73     
- Partials        2178     2197       +19
Impacted Files Coverage Δ Complexity Δ
...samtools/cram/structure/CramCompressionRecord.java 92.969% <ø> (ø) 113 <0> (ø) ⬇️
.../samtools/cram/build/CompressionHeaderFactory.java 90.11% <100%> (ø) 64 <0> (ø) ⬇️
...n/java/htsjdk/samtools/cram/structure/SliceIO.java 84.524% <0%> (+1.19%) 15% <0%> (+1%) ⬆️
...c/main/java/htsjdk/samtools/util/IntervalList.java 76.321% <0%> (+2.424%) 131% <0%> (+62%) ⬆️
...java/htsjdk/samtools/cram/structure/Container.java 91.781% <0%> (+3.737%) 31% <0%> (+4%) ⬆️
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️
...ain/java/htsjdk/samtools/cram/structure/Slice.java 72.174% <0%> (+4.581%) 67% <0%> (+24%) ⬆️
...va/htsjdk/samtools/cram/structure/ContainerIO.java 68.056% <0%> (+4.722%) 10% <0%> (ø) ⬇️
...main/java/htsjdk/variant/vcf/AbstractVCFCodec.java 79.2% <0%> (+5.354%) 145% <0%> (+59%) ⬆️
src/main/java/htsjdk/samtools/util/Interval.java 66.667% <0%> (+5.376%) 43% <0%> (+15%) ⬆️

@cmnbroad cmnbroad merged commit 0b9fe0d into master May 6, 2019
@cmnbroad cmnbroad deleted the jt_tags branch May 6, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants