Simplify CRAM sequence dictionary extractor to not require a fake reference. #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
===============================================
- Coverage 67.653% 67.648% -0.005%
+ Complexity 8195 8193 -2
===============================================
Files 560 560
Lines 33493 33494 +1
Branches 5638 5640 +2
===============================================
- Hits 22659 22658 -1
Misses 8652 8652
- Partials 2182 2184 +2
|
yfarjoun
approved these changes
Feb 27, 2019
lbergelson
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly more idiomatic CRAM sequence dictionary extractor. Rather than introduce a new method and fake reference in CRAMIterator, this retrieves the CRAM header and sequence dictionary using existing code that doesn't require a reference.