-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAMSequenceDictionaryExtractor doesn't handle CRAMs #731
Labels
Comments
I have an implementation of a solution that involves the following:
Does that sounds like a reasonable solution? |
5 tasks
the implementation can be viewed here: #732 |
One other option - it might be less intrusive to just crack the file open. Given a stream on the file, I think its a one-liner to get the header without the reference, i.e.: CramIO.readCramHeader(inputStream).getSamFileHeader() |
This was fixed in #1308. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just adding the cram extension to the list of extensions used by the SAM handler won't work unless a method overload is added that accepts a reference. Alternative it would be possible to have a custom handler that bypasses the SAMReader and just retrieves the header directly, since the reference isn't needed to just do that.
The text was updated successfully, but these errors were encountered: