-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate SQTagUtil #1214
Deprecate SQTagUtil #1214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
===============================================
+ Coverage 68.702% 68.708% +0.006%
Complexity 8061 8061
===============================================
Files 542 542
Lines 32711 32711
Branches 5533 5533
===============================================
+ Hits 22473 22475 +2
+ Misses 8038 8036 -2
Partials 2200 2200
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magicDGS I reworded your comment a little bit. Good catch!
@@ -27,7 +27,9 @@ | |||
* Utility methods for encoding and decoding the SQ tag value of SAMRecord. | |||
* | |||
* @author [email protected] | |||
* @deprecated since 11/2018. SQ is a reserved tag that shouldn't be used and this code untested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @deprecated since 11/2018. SQ is a reserved tag that shouldn't be used and this code untested. | |
* @deprecated since 11/2018. SQ is a deprecated tag that should no longer be used. This code is untested and and unsupported. There is no replacement for these utilities. |
I'm going to merge this as is because I want it to go in at the same time as the other samtag deprecations. |
Sorry for not answering - I had too much problems last months and I could not focus on this. Thanks for merging! |
Description
Closes #949
Checklist