Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete long-term deprecated code #1213

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

magicDGS
Copy link
Member

Description

Closes #955
Closes #972

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

@codecov-io
Copy link

codecov-io commented Oct 28, 2018

Codecov Report

Merging #1213 into master will increase coverage by 0.137%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #1213       +/-   ##
===============================================
+ Coverage     68.702%   68.839%   +0.137%     
+ Complexity      8061      8059        -2     
===============================================
  Files            542       540        -2     
  Lines          32711     32640       -71     
  Branches        5533      5523       -10     
===============================================
- Hits           22473     22469        -4     
+ Misses          8038      7969       -69     
- Partials        2200      2202        +2
Impacted Files Coverage Δ Complexity Δ
...samtools/util/AsyncBlockCompressedInputStream.java 72% <0%> (-4%) 12% <0%> (-1%)
...va/htsjdk/samtools/sra/SRAIndexedSequenceFile.java 62.162% <0%> (-2.703%) 6% <0%> (-1%)

@tfenne tfenne self-requested a review October 30, 2018 12:45
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for doing this.

@lbergelson lbergelson merged commit 1e6454b into samtools:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants