Build PDFs and comment on PRs using GitHub Actions #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarshall
force-pushed
the
robot-actions
branch
from
224db24
to
9844ce1
Compare
Use GitHub's recommended two-part approach [1][2] to separate building the PDFs (which runs in the PR branch's context and has only a read-only GH token) from commenting on the PR (which runs on the master branch and has write access to the repository). Add a brief README (to be expanded as this beds in), and mention in the old README that the old implementation will soon be removed: the CircleCI web hook and its access token have been removed from the hts-specs repo. [1] https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ [2] https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow
jmarshall
force-pushed
the
robot-actions
branch
from
9844ce1
to
6a7c138
Compare
|
The CircleCI integration has not been working for a while — it runs successfully and comments on PRs, but the links mostly lead to 404s rather than usable PDFs — so I have now deactivated it. To be precise, I have removed the CircleCI web hook and PAT from the hts-specs repository; I don't know if anything ought to be deactivated on the CircleCI side too. |
|
Now merged, as it has been gestating more than long enough and can only really be effectively tested in production(!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GitHub's recommended two-part approach12 to separate building the PDFs (which runs in the PR branch's context and has only a read-only GH token) from commenting on the PR (which runs on the master branch and has write access to the repository).
See jmarshall#2 and jmarshall#3 for examples of this running in that repository.
Footnotes
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ ↩
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow ↩