Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Testing CI updates #576

Closed
wants to merge 2 commits into from
Closed

[TEST] Testing CI updates #576

wants to merge 2 commits into from

Conversation

jmarshall
Copy link
Member

No description provided.

@jmarshall
Copy link
Member Author

It seems that Cheng Xu's image is missing both make and git, which complicates just moving to it…

@jmarshall jmarshall closed this Jun 9, 2021
@jmarshall jmarshall deleted the ci branch June 9, 2021 13:16
@jmarshall jmarshall restored the ci branch June 10, 2021 08:27
@jmarshall jmarshall reopened this Jun 10, 2021
Add step installing tools that we use that are missing from this image.
@hts-specs-bot
Copy link

Changed PDFs as of 6aaa376: SAMv1 (diff).

@lbergelson
Copy link
Member

@jmarshall What's the advantage of the new image? If you want to switch to it I'd recommend we bake a new custom image based on that with the tools we need added in already.

@jmarshall
Copy link
Member Author

The advantage of using someone else's image is that we don't have to maintain an image ourselves. In particular, xu-cheng/latex-docker is automatically rebuilt periodically, so we'd go from an outdated image to one automatically kept up to date.

But this PR was really just me experimenting with the quick update to get this going again — so really I should get back to it if it's supposed to be a quick fix! 😄 If you want to build an updated image please feel free.

However this is a bit of a stopgap. I have also been looking at reimplementing this on GitHub Actions and using a different method to attach the PDFs to PR comments (thus solving #555) — see another stalled experiment in my jmarshall/actions branch.

@michaelmhoffman
Copy link
Contributor

Are you still thinking about updating the TeX environment? I am still getting build failures on #570 because I am using features not available in the old TeX Live 2015 installation on CircleCI.

@michaelmhoffman
Copy link
Contributor

Could we please discuss on the 2021-10-14 meeting? I would tag Amreen but I can't figure out her GitHub username.

@michaelmhoffman
Copy link
Contributor

A recent enough TeX Live should be included in recent Ubuntu releases (21.04 or 21.10). Unfortunately, I don't think the last LTS release (20.04) is recent enough, and don't know how difficult it is to get a non-LTS Ubuntu image for CircleCI.

@jmarshall
Copy link
Member Author

jmarshall commented Mar 28, 2022

Experiments continue on jmarshall#1, which is almost ready to land. In summary:

  1. Uses GitHub Actions; we can retire the Circle CI integration.
  2. Uses the TeXLive project's own docker image, which is updated periodically.
  3. Stores the PDFs as commits in the hts-specs repository (not on a branch, so that they are not fetched by default; on a ref, so they are not garbage collected), thus solving Persisting pdf artifacts? #555.
  4. Currently comments as “github-actions (bot)”; we may wish to retire @hts-specs-bot (though the commits do need an author and email address, which currently uses hts-specs-bot's details).

Happy to discuss the details at tomorrow's meeting, or a PR will be appearing in due course.

@jmarshall
Copy link
Member Author

This test PR is now superseded by those continuing experiments, which are now #641.

@jmarshall jmarshall closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants