-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Testing CI updates #576
Conversation
It seems that Cheng Xu's image is missing both |
f61e155
to
8362a22
Compare
Add step installing tools that we use that are missing from this image.
@jmarshall What's the advantage of the new image? If you want to switch to it I'd recommend we bake a new custom image based on that with the tools we need added in already. |
The advantage of using someone else's image is that we don't have to maintain an image ourselves. In particular, xu-cheng/latex-docker is automatically rebuilt periodically, so we'd go from an outdated image to one automatically kept up to date. But this PR was really just me experimenting with the quick update to get this going again — so really I should get back to it if it's supposed to be a quick fix! 😄 If you want to build an updated image please feel free. However this is a bit of a stopgap. I have also been looking at reimplementing this on GitHub Actions and using a different method to attach the PDFs to PR comments (thus solving #555) — see another stalled experiment in my jmarshall/actions branch. |
Are you still thinking about updating the TeX environment? I am still getting build failures on #570 because I am using features not available in the old TeX Live 2015 installation on CircleCI. |
Could we please discuss on the 2021-10-14 meeting? I would tag Amreen but I can't figure out her GitHub username. |
A recent enough TeX Live should be included in recent Ubuntu releases (21.04 or 21.10). Unfortunately, I don't think the last LTS release (20.04) is recent enough, and don't know how difficult it is to get a non-LTS Ubuntu image for CircleCI. |
Experiments continue on jmarshall#1, which is almost ready to land. In summary:
Happy to discuss the details at tomorrow's meeting, or a PR will be appearing in due course. |
This test PR is now superseded by those continuing experiments, which are now #641. |
No description provided.