Tidy up longtable captions and labels [minor] #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly I see latexdiff is failing. I've had this recently too in other projects. I really struggled to get it to not produce buggy output within a few specific tables, and in the end took the approach of producing a new table environment specifically to avoid latexdiff from exploding. Ie: That rather sucks though! |
|
I suspect Yossi (#404) and Michael (#570 (comment)) are correct in their theory that these latexdiff failures are down to cross-references to filtered-out unchanged pages. I consider that a limitation within latexdiff that we should hope they fix in due course, and the revamped CI infrastructure will ignore these latexdiff failures rather than failing the whole thing. |
jmarshall
force-pushed
the
table-captions
branch
from
cbf07d5
to
5380fec
Compare
Move \label to \endlastfoot so it is emitted once even for a multi-page table. Fixes samtools#605. We don't currently use \listoftables; nonetheless use \caption[] in \endfoot (and plain \caption in \endlastfoot) so only one contents entry is emitted per table. Move the "Continued..." text away from \endfirsthead and \endlastfoot so that it is suppressed when the table is not broken across multiple pages.
jmarshall
force-pushed
the
table-captions
branch
from
5380fec
to
7af8fbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes to the text or even to the formatting. Removes a LaTeX warning.
Move
\labelto\endlastfootso it is emitted once even for a multi-page table. Fixes #605.We don't currently use
\listoftables; nonetheless use\caption[]and\caption[TOC_text]{…}to emit only one contents entry per table.