Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table:reserved-genotypes multiply defined in VCFv4.3.tex and VCFv4.4.draft.tex #605

Closed
michaelmhoffman opened this issue Nov 2, 2021 · 0 comments · Fixed by #621
Closed

table:reserved-genotypes multiply defined in VCFv4.3.tex and VCFv4.4.draft.tex #605

michaelmhoffman opened this issue Nov 2, 2021 · 0 comments · Fixed by #621
Labels
vcf

Comments

@michaelmhoffman
Copy link
Contributor

Building VCFv4.3.tex and VCFv4.4.draft.tex files leads to this warning:

LaTeX Warning: Label `table:reserved-genotypes' multiply defined.

This is probably because of the way the \label is applied in a longtable \endhead block rather than \endfirsthead so it appears only once.

I found this because my personal .latexmkrc includes $warnings_as_errors = 1;. If you want these sorts of warnings to lead to errors (which I suggest), you can add -Werror to LATEXMK_FLAGS. If you have this personal setting in .latexmkrc but want this to build anyway, you can workaround with

make LATEXMK_FLAGS="-e '\$\$warnings_as_errors=0;'"
@jkbonfield jkbonfield added the vcf label Nov 11, 2021
jmarshall added a commit to jmarshall/hts-specs that referenced this issue Jan 5, 2022
@jmarshall
Tidy up longtable captions and labels [minor]
cbf07d5 
Move \label to \endlastfoot so it is emitted once even for a
multi-page table. Fixes samtools#605.

We don't currently use \listoftables; nonetheless use \caption[]
and \caption[TOC_text]{...} to emit only one contents entry per table.
(This is emitted from \endfoot so would need revisiting if a table
goes over more than two pages.)
@jmarshall jmarshall mentioned this issue Jan 5, 2022
Merged
jmarshall added a commit to jmarshall/hts-specs that referenced this issue Jan 6, 2022
@jmarshall
Tidy up longtable captions and labels [minor]
5380fec 
Move \label to \endlastfoot so it is emitted once even for a
multi-page table. Fixes samtools#605.

We don't currently use \listoftables; nonetheless use \caption[]
and \caption[TOC_text]{...} to emit only one contents entry per table.
(This is emitted from \endfoot so would need revisiting if a table
goes over more than two pages.)
jmarshall added a commit to jmarshall/hts-specs that referenced this issue Jan 6, 2022
@jmarshall
Tidy up longtable captions and labels [minor]
7af8fbd 
Move \label to \endlastfoot so it is emitted once even for a
multi-page table. Fixes samtools#605.

We don't currently use \listoftables; nonetheless use \caption[]
in \endfoot (and plain \caption in \endlastfoot) so only one contents
entry is emitted per table. Move the "Continued..." text away from
\endfirsthead and \endlastfoot so that it is suppressed when the table
is not broken across multiple pages.
d-cameron pushed a commit that referenced this issue Apr 19, 2022
@jmarshall
Tidy up longtable captions and labels [minor] (#621)
4f5a0fe 
Move \label to \endlastfoot so it is emitted once even for a
multi-page table. Fixes #605.

We don't currently use \listoftables; nonetheless use \caption[]
in \endfoot (and plain \caption in \endlastfoot) so only one contents
entry is emitted per table. Move the "Continued..." text away from
\endfirsthead and \endlastfoot so that it is suppressed when the table
is not broken across multiple pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vcf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tidy up longtable captions and labels [minor] jmarshall/hts-specs
2 participants
@jkbonfield @michaelmhoffman