Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add markers #2386

Merged
merged 1 commit into from
Feb 12, 2022
Merged

feat: add markers #2386

merged 1 commit into from
Feb 12, 2022

Conversation

ForeverSc
Copy link
Contributor

Link to related issue (if applicable)

#278

Summary of proposed changes

add markers option to custom some markers on the progress bar

...
markers: {
  enabled: true,
  points: [
    {
      time: 10, // marker point time
      tip: 'first marker', // marker point hover display tip
    },
    {
      time: 20,
      tipHTML: '<strong>second</strong> marker', // or you can custom marker hover tip by innerHTML
    }
  ]
}
...

image

@adeeb1 adeeb1 mentioned this pull request Jan 18, 2022
@adeeb1
Copy link

adeeb1 commented Jan 18, 2022

Love this feature! For those interested, I've merged it into my fork with a few additional changes. Here's the PR: ClassHook#8

@ForeverSc feel free to include some of those changes in this PR if you think they're relevant. I'd also be happy to create a separate PR if it's easier.

@lofcz
Copy link

lofcz commented Jan 18, 2022

@sampotts can we get this merged?

@sampotts sampotts merged commit 4632614 into sampotts:master Feb 12, 2022
@sampotts
Copy link
Owner

Thanks! I'll write up some docs and get this published!

@maxiR8
Copy link

maxiR8 commented Apr 7, 2022

Can you please make a new release with these additions? Latest release doesn't work with the markers.

@sampotts
Copy link
Owner

Thanks for the work on this. I've made a few small changes to the API (simplified the content to label property which accepts a string or HTML) and UI (combined the label into any existing tooltip or preview thumbnail) for it but it's mostly as-is!

Thanks again. It's in v3.7.0 🎉

@evansque
Copy link

This is awesome, thanks @sampotts I've been really waiting for this release

@sampotts
Copy link
Owner

Thanks, @evansque. The current Plyr UI design doesn't really adapt well to chapter/marker support but it's definitely something we'll consider for the Vidstack UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants