-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markers #8
Add markers #8
Conversation
Remove package-lock in favor of yarn.lock. Update dist files.
Update the UI accordingly as markers are set. Update README with documentation for markers. Add TypeScript types for markers.
@adeeb1 would you please explain to me how to set markers on a Plyr object? (if there is a specific method to use) thank you! 🙏🏻 |
@zamoosh Hi! Sure, you can do it by setting the value of the
For example:
|
@adeeb1 but it's not working yet! Is it possible to add markers after initialing the object? |
@zamoosh This fork deviates from the main API, as we don't use a Yes, it is possible to add markers after initializing the object. Try something like this to make sure it works at initializing:
|
@adeeb1 thanks a lot! 🙏🏻 😃 |
@adeeb1 |
@zamoosh Glad to help! Make sure to use |
Cherry-picked from the great work done by ForeverSc: https://github.com/ForeverSc/plyr/tree/feat/markers
Pull request in main repo: sampotts#2386
This branch also: