Improve support for linear ads (fixes #1746) #1749
Conversation
| if(ad.width > 480){ | ||
| var controlHeight = 40; | ||
| }else{ | ||
| var controlHeight = 60; | ||
| } |
There was a problem hiding this comment.
No, I Couldn't find the current height of the control bar how ever this value will result the advertisment above the controls.
http://mol-clan.nl/dump/plyrads.png
Maybe the best would be if course it moves up when the controls are in screen.
this.elements.container.style.zIndex = 3;
Means the controls are not usable any more..
Maybe the the div in side the .plyr__ads needs a z-index instead of the .plyr_ads div to solve the problem prefectly
Also on resize (full screen or back the banner will drop down to the bottom edge...)
There was a problem hiding this comment.
Hmm are the controls even needed for those ads? They should be hidden I'd say? Where did you get the tag from to test this?
There was a problem hiding this comment.
On the following page you have multiple versions...
https://developers.google.com/interactive-media-ads/docs/sdks/html5/tags
When search on google IMA test tags it is the first result.
The current one I am using is the Non Linear one
If needed I have also a few testing tags running on a website for banners acting like a preroll and mulitple test tags from ad providers.
In this case the video is just playing normally so to control the video it self you will need controls.
Those ads are comparable with ads during video play on Youtube.
Maybe a wise idea to add a test page for easy testing ad related items
Made this in the. past for VideoJS
http://mol-clan.nl/videojs-test/?vasttag=8
There was a problem hiding this comment.
Also for me personally this behaviour would be the best:
http://mol-clan.nl/videojs-test/?vasttag=8
When the controls are hidden it should be hidden again
See my screen recording
http://mol-clan.nl/dump/recording.mov
Link to related issue (if applicable)
#1746
Summary of proposed changes
Changed few lines for non Linear Ads played during video it self. Before the ads event are trigged how ever the z-index was removed during resumeContent();
This will be added again.
Disable pollCountdown when this kind of add is loaded and hide the bubble
Last I moved the advertisement a few pixels up by default maybe should be changed later on that this only happen when controls are enabled?
Checklist
developas the base branch/distchanges) from the PRTested on Chrome, Safari. Unable to test on Windows...