Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function api2 #31

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Function api2 #31

merged 5 commits into from
Aug 1, 2024

Conversation

sameoldlab
Copy link
Owner

fixes issues with importing styles from #25 . Should make importing as either a function or component equally predictable.

switch bundler to @svelte/package
add svelte-preprocess to handle global styles
Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: d6cd664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fractl-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 4:38pm

@sameoldlab
Copy link
Owner Author

I can't think of a place where someone might want both ConnectModal and AccountModal individually. FractlModal works better in that situation and handles promises and transition better. This has too much boilerplate, but doesn't even work. account is a different object from config (so they won't swap, wrapping it all in await doesn't work because checking for connection needs the state and accountData stores destructured, while passing props, needs it to be whole.

{#if account}
	<AccountModal {...account} />
{:else}
	{#await evm then config}
		<ConnectModal {config} state={config.state} {onConnect}/>
	{/await}
{/if}

@sameoldlab sameoldlab merged commit 27eeaba into main Aug 1, 2024
3 checks passed
@sameoldlab sameoldlab deleted the function-api2 branch August 1, 2024 16:39
sameoldlab added a commit that referenced this pull request Aug 12, 2024
* migrating

switch bundler to @svelte/package
add svelte-preprocess to handle global styles

* correct types

* update example

* account might be null

* clarify component use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant