feat: Implement a query stack Backtrace analog#827
Merged
Veykril merged 1 commit intosalsa-rs:masterfrom Apr 29, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #827 will not alter performanceComparing Summary
|
MichaReiser
reviewed
Apr 29, 2025
tests/backtrace.rs
Outdated
| let backtrace = query_a(&db, Thing::new(&db, true)).replace("\\", "/"); | ||
| expect![[r#" | ||
| query stacktrace: | ||
| 0: query_a(Id(1)) -> (R1, Durability::HIGH) |
Contributor
There was a problem hiding this comment.
Wow, this is so useful that I sort of want this for non-panicks too :)
Member
Author
There was a problem hiding this comment.
This is pretty nice actually
Contributor
There was a problem hiding this comment.
I find it more useful than most tracing we have in place today.
0cddadd to
fa0b2f2
Compare
Backtrace analogBacktrace analog
fa0b2f2 to
aaf862c
Compare
Member
Author
|
Just noticed the order was reversed to what a normal backtrace would look like, fixed that just now (the stack top is now at position 0 like it is for normal backtraces) |
This was referenced Apr 28, 2025
Merged
Merged
This was referenced Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example output: