better debug name for interned query arguments#837
Merged
davidbarsky merged 2 commits intosalsa-rs:masterfrom Apr 30, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #837 will not alter performanceComparing Summary
|
MichaReiser
force-pushed
the
better-debug-name-for-interned-query-arguments
branch
from
6dbc86a to
77599c7
Compare
davidbarsky
approved these changes
Apr 30, 2025
| line: line!(), | ||
| }; | ||
| const DEBUG_NAME: &'static str = "Configuration"; | ||
| const DEBUG_NAME: &'static str = concat!(stringify!($fn_name), "_arguments"); |
Contributor
There was a problem hiding this comment.
maybe something like?
Suggested change
| const DEBUG_NAME: &'static str = concat!(stringify!($fn_name), "_arguments"); | |
| const DEBUG_NAME: &'static str = concat!(stringify!($fn_name), "_interned_args"); |
(In general, I'm a +1 on this change.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug name
Configurationisn't very helpful when debugging salsa. Use a name constructed from the query name.I'm open to suggestions on how to avoid collisions with actual query names. e.g. we could prefix the name with two underscores or similar.