chore: Adjust #[inline] annotations#799
Merged
Veykril merged 1 commit intosalsa-rs:masterfrom Apr 17, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #799 will improve performances by 5.43%Comparing Summary
Benchmarks breakdown
|
Veykril
force-pushed
the
veykril/push-kuyvqkxovmml
branch
6 times, most recently
from
86125d0 to
3f2b148
Compare
Veykril
changed the title
#[inline] some things#[inline] annotations
Veykril
force-pushed
the
veykril/push-kuyvqkxovmml
branch
from
3f2b148 to
942d501
Compare
Veykril
force-pushed
the
veykril/push-kuyvqkxovmml
branch
from
942d501 to
baf8945
Compare
Veykril
commented
Apr 17, 2025
| self.database_key_index(id), | ||
| )) | ||
| { | ||
| if !memo.provisional_retry(db, zalsa, self.database_key_index(id)) { |
Member
Author
There was a problem hiding this comment.
provisional_retry itself already calls may_be_provisional()
Member
Author
|
I'll self-approve this, as this doesn't change behavior and hopefully makes CI benches more reliable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of attached calls/definitions seem to hover around the default inlining limit making the codspeed reports difficult to interpret at times, generally these should benefit from being inlined either way as the "attached" code paths are quite hot.
Aside from those, this PR touches up on a lot of other call sites for instructing inlining behavior, as just changing the attached calls has a negative impact overall on the remainder of the inlining behaviors. These additional explicit annotations bring things back in line.