Remove incorrect parallel_scope API#797
Merged
nikomatsakis merged 1 commit intosalsa-rs:masterfrom Apr 16, 2025
Merged
Conversation
Rayon does not allow joining on the spawns, meaning we might end up with results in the tests before reading out the panics
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #797 will not alter performanceComparing Summary
|
nikomatsakis
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rayon does not allow joining on the spawns, meaning we might end up with results in the tests before reading out the panics
This API is generally brittle so lets remove it
Fixes #795