Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #790 will not alter performanceComparing Summary
|
MichaReiser
left a comment
There was a problem hiding this comment.
I think that's not just useful for third-party tests but also for our own. We don't have good infrastructure to set up tracing in tests, which is why I mainly use the db events to debug test errors (with occasional println sprinkled in every now and there)
MichaReiser
left a comment
There was a problem hiding this comment.
I think that's not just useful for third-party tests but also for our own. We don't have good infrastructure to set up tracing in tests, which is why I mainly use the db events to debug test errors (with occasional println sprinkled in every now and there). In fact, I had to add multiple println expressions to verify that my test used the cycle head that I intended.
Side note from this PR, but if you replace |
Ohhh nice, I didn't know about that. |
I would like to write tests asserting about cycles iterated and log cycles iterated as a metric. Add a
WillIterateCycleevent and fire it whenever a cycle head is about to iterate the cycle again. Update some cycle tests accordingly.