Skip to content

chore: Document most safety blocks#776

Merged
Veykril merged 2 commits intosalsa-rs:masterfrom
detrumi:enforce-undocumented-unsafe-blocks
Mar 23, 2025
Merged

chore: Document most safety blocks#776
Veykril merged 2 commits intosalsa-rs:masterfrom
detrumi:enforce-undocumented-unsafe-blocks

Conversation

@detrumi
Copy link
Contributor

@detrumi detrumi commented Mar 23, 2025

Makes a start on #697, but doesn't forbid clippy::undocumented_unsafe_blocks yet.
Some files with many undocumented blocks allow the lint on file level for now to reduce noise.

@netlify
Copy link

netlify bot commented Mar 23, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 87a3ae0
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67dfeb992de73d00085845e1

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 23, 2025

CodSpeed Performance Report

Merging #776 will not alter performance

Comparing detrumi:enforce-undocumented-unsafe-blocks (87a3ae0) with master (3043395)

Summary

✅ 12 untouched benchmarks

@detrumi detrumi force-pushed the enforce-undocumented-unsafe-blocks branch from 096b00f to 33b3b93 Compare March 23, 2025 07:40
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril added this pull request to the merge queue Mar 23, 2025
@Veykril Veykril changed the title Document most safety blocks chore: Document most safety blocks Mar 23, 2025
Merged via the queue into salsa-rs:master with commit 8fb172b Mar 23, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Mar 23, 2025
@detrumi detrumi deleted the enforce-undocumented-unsafe-blocks branch March 23, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants