refactor: Keep edge condvar on the stack#773
Merged
Veykril merged 1 commit intosalsa-rs:masterfrom Apr 5, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #773 will not alter performanceComparing Summary
|
Member
Author
|
Okay I think this does confirm that the benches are really sensitive to allocation changes. This should not regress performance whatsoever. |
Veykril
changed the title
Arc
Veykril
force-pushed
the
veykril/push-nmzmtvrqwwuv
branch
from
c0081cd to
83b1ce2
Compare
Veykril
force-pushed
the
veykril/push-nmzmtvrqwwuv
branch
2 times, most recently
from
00f2614 to
b12d5f5
Compare
MichaReiser
approved these changes
Apr 5, 2025
Contributor
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
I'm a bit concerned about the amount of unsafe code in salsa. But maybe that's just me because I'm not used to writing unsafe code. Avoiding an allocation in add_edge certainly is nice. But it's not entirely clear when we think that using unsafe is justified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an unnecessary heap allocation when recording a dependency edge