Skip to content

Replace memo queue with append-only vector#767

Merged
MichaReiser merged 2 commits intosalsa-rs:masterfrom
ibraheemdev:memo-queue
Mar 20, 2025
Merged

Replace memo queue with append-only vector#767
MichaReiser merged 2 commits intosalsa-rs:masterfrom
ibraheemdev:memo-queue

Conversation

@ibraheemdev
Copy link
Member

Should be an easy win here.

@netlify
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 6c18ee8
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67dc352ca92a2c0008a876ae

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #767 will not alter performance

Comparing ibraheemdev:memo-queue (6c18ee8) with master (e826b5a)

Summary

✅ 12 untouched benchmarks

@ibraheemdev
Copy link
Member Author

I guess this will be obselete if #660 ever lands.

@ibraheemdev
Copy link
Member Author

ibraheemdev commented Mar 20, 2025

Weirdly, 47f8917 on its own was a 5% improvement before the boxcar update.. now it's a regression, despite #696 showing an improvement.

@Veykril
Copy link
Member

Veykril commented Mar 20, 2025

I believe our benches have become fast enough that they turn noisy again unfortunately, especially report_tracked_read jumps randomly and that code is inserting into a hashmap, so its likely allocation noise still.

@Veykril
Copy link
Member

Veykril commented Mar 20, 2025

I suppose this resolves #733?

@MichaReiser
Copy link
Contributor

This looks good. I'll hit the merge button because @ibraheemdev isn't a contributor yet (we should bring this up in our next salsa meeting or on zulip)

@MichaReiser MichaReiser added this pull request to the merge queue Mar 20, 2025
@MichaReiser MichaReiser removed this pull request from the merge queue due to a manual request Mar 20, 2025
@MichaReiser MichaReiser enabled auto-merge March 20, 2025 15:39
@MichaReiser MichaReiser added this pull request to the merge queue Mar 20, 2025
Merged via the queue into salsa-rs:master with commit ea99739 Mar 20, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants