Replace memo queue with append-only vector#767
Merged
MichaReiser merged 2 commits intosalsa-rs:masterfrom Mar 20, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #767 will not alter performanceComparing Summary
|
Member
Author
|
I guess this will be obselete if #660 ever lands. |
Member
Author
Member
|
I believe our benches have become fast enough that they turn noisy again unfortunately, especially |
Member
|
I suppose this resolves #733? |
Veykril
approved these changes
Mar 20, 2025
Contributor
|
This looks good. I'll hit the merge button because @ibraheemdev isn't a contributor yet (we should bring this up in our next salsa meeting or on zulip) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be an easy win here.