perf: Reduce unnecessary conditional work in deep_verify_memo#759
Merged
Veykril merged 2 commits intosalsa-rs:masterfrom Mar 16, 2025
Merged
perf: Reduce unnecessary conditional work in deep_verify_memo#759Veykril merged 2 commits intosalsa-rs:masterfrom
deep_verify_memo#759Veykril merged 2 commits intosalsa-rs:masterfrom
Conversation
Veykril
changed the title
deep_verify_memodeep_verify_memo
✅ Deploy Preview for salsa-rs canceled.
|
Veykril
force-pushed
the
veykril/push-qwnqomnyoszy
branch
from
e534881 to
585e551
Compare
Veykril
changed the title
deep_verify_memodeep_verify_memo
CodSpeed Performance ReportMerging #759 will not alter performanceComparing Summary
|
carljm
approved these changes
Mar 15, 2025
| ) -> bool { | ||
| // Wouldn't it be nice if rust had an implication operator ... | ||
| // may_be_provisional -> validate_provisional | ||
| !memo.may_be_provisional() || self.validate_provisional(db, zalsa, database_key_index, memo) |
Contributor
There was a problem hiding this comment.
Would it be just as good to not add this additional wrapper, and instead just check memo.may_be_provisional inside validate_provisional? This is the only call site of validate_provisional.
Member
Author
There was a problem hiding this comment.
This seems to regress perf, presumably due to inlining changes
Veykril
force-pushed
the
veykril/push-qwnqomnyoszy
branch
from
8fd0787 to
f0b42a6
Compare
Veykril
force-pushed
the
veykril/push-qwnqomnyoszy
branch
from
f0b42a6 to
a93ab09
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Veykril
force-pushed
the
veykril/push-qwnqomnyoszy
branch
3 times, most recently
from
0e16289 to
d3e66bc
Compare
Veykril
force-pushed
the
veykril/push-qwnqomnyoszy
branch
from
d3e66bc to
f7df1d3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.