feat: Drop Debug requirements and flip implementation defaults#756
Merged
Veykril merged 1 commit intosalsa-rs:masterfrom Mar 15, 2025
Merged
feat: Drop Debug requirements and flip implementation defaults#756Veykril merged 1 commit intosalsa-rs:masterfrom
Debug requirements and flip implementation defaults#756Veykril merged 1 commit intosalsa-rs:masterfrom
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #756 will not alter performanceComparing Summary
|
c7c6d32 to
dc2cefb
Compare
MichaReiser
reviewed
Mar 15, 2025
Contributor
MichaReiser
left a comment
There was a problem hiding this comment.
This makes sense to me.
Would it be possible to inspect the structs derive attribute and only generate the Debug impl if someone derived Debug (and then remove it). Or should we add our own DebugSalsa derive macro?
Member
Author
I believe that should be doable but:
I think a custom salsa debug derive might be the better option for this. It definitely sounds like the more proper way to do this (though I'd do that as a follow up). |
dc2cefb to
c18063c
Compare
c18063c to
a244890
Compare
MichaReiser
approved these changes
Mar 15, 2025
Merged
This was referenced Apr 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default caused a pretty severe hang for us in rust-analyzer due to a debug implementation formatting the entire dependency tree for each dependency recursively by accident so this proposes flipping the default.
This also drops a bunch of debug bounds internal which are unnecessary (without that you are required to somehow implement
Debugfor most salsa structs).