refactor: Clean up par_map a bit#742
Merged
Veykril merged 5 commits intosalsa-rs:masterfrom Mar 24, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #742 will not alter performanceComparing Summary
|
Veykril
force-pushed
the
veykril/push-rmymmuwytuzz
branch
from
0b52a49 to
e908a34
Compare
Veykril
force-pushed
the
veykril/push-rmymmuwytuzz
branch
from
e908a34 to
4107aa6
Compare
Veykril
force-pushed
the
veykril/push-rmymmuwytuzz
branch
2 times, most recently
from
c525227 to
1f6f19b
Compare
Member
Author
|
@davidbarsky bad news, the current impl of |
Veykril
force-pushed
the
veykril/push-rmymmuwytuzz
branch
from
1f6f19b to
6fd03f3
Compare
Veykril
force-pushed
the
veykril/push-rmymmuwytuzz
branch
from
6fd03f3 to
a8e9ed7
Compare
Contributor
Crap, I'm hoping this is fixable. |
Member
Author
|
It is, we just need to eagerly |
Veykril
force-pushed
the
veykril/push-rmymmuwytuzz
branch
from
fe2d474 to
bc8e406
Compare
Member
Author
|
Fixed the issue and added some more tests for the other new APIs |
Contributor
|
Changes look good to me. Should we add a |
davidbarsky
approved these changes
Mar 24, 2025
Member
Author
|
We could |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.