Add local alias for toString
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @corvidism to sign the Salesforce Inc. Contributor License Agreement. |
|
Thanks for the contribution! Before we can merge this, we need @inikulin @stash-sfdc to sign the Salesforce Inc. Contributor License Agreement. |
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Yevhen Lukomskyi <Y***@3***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
|
@corvidism thanks for the PR! Now I just have to figure out how to backport this into the |
|
Great! Thanks for the effort. |
|
Closing and reopening to see if it fixes the synk PR checks. |
colincasey
approved these changes
Apr 26, 2024
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
May 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tough-cookie](https://github.com/salesforce/tough-cookie) | [`4.1.3` -> `4.1.4`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.3/4.1.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v4.1.4`](https://github.com/salesforce/tough-cookie/releases/tag/v4.1.4) [Compare Source](https://github.com/salesforce/tough-cookie/compare/v4.1.3...v4.1.4) https://www.npmjs.com/package/tough-cookie/v/4.1.4 #### What's Changed - Add local alias for `toString` by [@​corvidism](https://github.com/corvidism) in [salesforce/tough-cookie#409 - Fix incorrect string validation for URL by [@​coditva](https://github.com/coditva) in [salesforce/tough-cookie#261 #### New Contributors - [@​corvidism](https://github.com/corvidism) made their first contribution in [salesforce/tough-cookie#409 - [@​coditva](https://github.com/coditva) made their first contribution in [salesforce/tough-cookie#261 **Full Changelog**: salesforce/tough-cookie@v4.1.3...v4.1.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
toStringtoObject.prototype.toStringas the code implicitly expects, to avoid conflicts with mocked globals. (see issue #405).