Fix incorrect string validation for URL #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @coditva to sign the Salesforce.com Contributor License Agreement. |
|
It seems there's some error with the CLA bot. I've signed the CLA, but the status is not updated. Let me know how to proceed here.
|
coditva
force-pushed
the
fix/url-string-validation
branch
from
77defa6
to
90f2b38
Compare
coditva
force-pushed
the
fix/url-string-validation
branch
from
90f2b38
to
cf6debd
Compare
|
Can you rebase your pull request against the 5.x branch? And resubmit? We are close to a release of that version of |
|
@coditva did you need this change backported for 4.x? the |
|
@colincasey @awaterma It'll be awesome if it was back-ported since it broke in 4.x and we're also using 4.x. But if that's not something that you're targeting/maintaining then I'll be open to getting this merged in 5.x. Thanks! |
colincasey
added a commit
that referenced
this pull request
Feb 5, 2024
This is a version of PR #261 that is compatible with our v5 TypeScript code.
colincasey
approved these changes
Apr 26, 2024
renovate bot
referenced
this pull request
in Unleash/unleash
May 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tough-cookie](https://github.com/salesforce/tough-cookie) | [`4.1.3` -> `4.1.4`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.3/4.1.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>salesforce/tough-cookie (tough-cookie)</summary> ### [`v4.1.4`](https://github.com/salesforce/tough-cookie/releases/tag/v4.1.4) [Compare Source](https://github.com/salesforce/tough-cookie/compare/v4.1.3...v4.1.4) https://www.npmjs.com/package/tough-cookie/v/4.1.4 #### What's Changed - Add local alias for `toString` by [@​corvidism](https://github.com/corvidism) in [https://github.com/salesforce/tough-cookie/pull/409](https://github.com/salesforce/tough-cookie/pull/409) - Fix incorrect string validation for URL by [@​coditva](https://github.com/coditva) in [https://github.com/salesforce/tough-cookie/pull/261](https://github.com/salesforce/tough-cookie/pull/261) #### New Contributors - [@​corvidism](https://github.com/corvidism) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/409](https://github.com/salesforce/tough-cookie/pull/409) - [@​coditva](https://github.com/coditva) made their first contribution in [https://github.com/salesforce/tough-cookie/pull/261](https://github.com/salesforce/tough-cookie/pull/261) **Full Changelog**: salesforce/tough-cookie@v4.1.3...v4.1.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getCookiesandsetCookiefunctions can handle URL objects. They used to handle it in v4.0.0 but it seems since 4.1.1, validations were added which don't allow using URL object. PR: #193This change updates the validations to allow both string and object.