fix(cookie-jar): use typeof for checking type of option #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around jestjs/jest#2549 when used in Jest
|
Thanks for the contribution! Before we can merge this, we need @SimenB to sign the Salesforce.com Contributor License Agreement. |
|
Ping! Can this be merged now? |
|
is there anything blocking this from merging? @ShivanKaul |
|
LGTM to me too. Shipping 🚢 |
|
Any ETA to actually release at least as a beta? |
|
We'll get a release discussion going in our next meeting. We have a few more p/rs we want to bring in, I think. I think you can do some local testing with our master branch by pulling in a GitHub dependency into your package.json. |
|
Went with patch-package solution for now. |
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
* chore: prepare for summer20 release (#143) * 0.8.0 * chore: update jest to v25.5.4 (#152) * chore: upgrade jest to 25.5.4 * 0.9.0 (#154) * Update stubs for Summer 20 (#150) * update stubs for Summer 20 * APPLICATION_SCOPE as symbol * 0.9.1 * chore: update yarn lock file Co-authored-by: Aliaksandr Papko <[email protected]> Co-authored-by: Trevor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around jestjs/jest#2549 when used in Jest