Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed IP address regex and thoroughly test #152

Closed
wants to merge 1 commit into from
Closed

Conversation

stash
Copy link
Collaborator

@stash stash commented Feb 27, 2019

Removes the dependency on ip-regex and adds test coverage on how exactly tough-cookie is treating IP addresses.

@stash
Copy link
Collaborator Author

stash commented Feb 27, 2019

See also: #151

@ruoho-sfdc
Copy link
Contributor

@stash Is this the IPv6 pull request you mentioned today?

@ruoho ruoho assigned ruoho and unassigned stash Aug 21, 2019
@awaterma awaterma added this to the 4.x Release milestone Dec 9, 2019
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruoho ruoho closed this Mar 5, 2020
wjhsf pushed a commit that referenced this pull request Feb 8, 2024
* chore: prepare for summer20 release (#143)

* 0.8.0

* chore: update jest to v25.5.4 (#152)

* chore: upgrade jest to 25.5.4

* 0.9.0 (#154)

* Update stubs for Summer 20 (#150)

* update stubs for Summer 20

* APPLICATION_SCOPE as symbol

* 0.9.1

* chore: update yarn lock file

Co-authored-by: Aliaksandr Papko <[email protected]>
Co-authored-by: Trevor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants